Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new comment section structure #613

Closed
4 tasks done
LuanRT opened this issue Mar 1, 2024 · 4 comments · Fixed by #614
Closed
4 tasks done

Add support for new comment section structure #613

LuanRT opened this issue Mar 1, 2024 · 4 comments · Fixed by #614
Labels
enhancement New feature or request

Comments

@LuanRT
Copy link
Owner

LuanRT commented Mar 1, 2024

Describe your suggestion

Looks like the comment nodes need to be updated using the mutation data found in the frameworkUpdates field. Each node has an id that can be used to identify its respective mutation.

Other details

We already handle some mutation data for YTMusic, so it shouldn't be difficult to do the same for YouTube.

Checklist

  • I am running the latest version.
  • I checked the documentation and found no answer.
  • I have searched the existing issues and made sure this is not a duplicate.
  • I have provided sufficient information.
@LuanRT LuanRT added the enhancement New feature or request label Mar 1, 2024
@LuanRT LuanRT self-assigned this Mar 1, 2024
@absidue
Copy link
Collaborator

absidue commented Mar 1, 2024

I have all the code for it already, I've worked on this in the last few days. Both for the comments and rewriting the attributed text handling so it can handle styling and emojis.

@absidue
Copy link
Collaborator

absidue commented Mar 1, 2024

I can create pull requests for both, I'm sorry that I haven't already done it yet.

@LuanRT
Copy link
Owner Author

LuanRT commented Mar 1, 2024

Oh that's lovely then! I was working on it as well, but since you already have it all prepared then feel free to submit your PRs. I'll review them right away.

@absidue
Copy link
Collaborator

absidue commented Mar 1, 2024

#614 handles the new CommentView nodes, it doesn't support the logged in only features such as leaving a reply or liking a comment, feel free to push commits to the pull request if you want to build on top of my changes.

#615 Refactors the attributed text handling, to support formatting and custom emojis, I've provided some examples in the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants