feat(parser): Support CommentView nodes #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new nodes that are used for comments
CommentView. Unlike most nodes in YouTube's responses, CommentView contains minimal data itself and instead contains a bunch of keys that reference mutations in the framework updates part of the API response.Compared to the old comments node, this pull request doesn't currently support the logged in features such as replying and liking a comment. It also doesn't have a way of identifying moderators, but I couldn't find any test cases and YouTube's
desktop_polymer.jsfile didn't provide any useful information concerning that either.@LuanRT Feel free to push commits to this pull request, if you want to address the missing login only features (the relevant innertube commands should be accessible via the
toolbar_surfacekey, although they are incomplete while logged out) or cleanup my handling of the mutations.closes #613