Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #934.
Checklist
Description
This is the specific sequence to break walk-jun-jump.
Lara_State_Run
;m_JumpPermitted
is set tofalse
LA_RUN (anim 0)
by rolling, for example;m_JumpPermitted
is still falseLara_State_Walk
and release walk. The state changes here will link toWALK_TO_RUN_RIGHT (anim 4)
orWALK_TO_RUN_LEFT (anim 5)
, depending on the frame.LA_RUN (0)
, but link to frame 8 or 19. Their state IDs are the same as walk, so control remains inLara_State_Walk
until the state change is processed.m_JumpPermitted
will remainfalse
until the frame cycles round again toLF_JUMP_READY (4)
- so 18 frames have to play out forWALK_TO_RUN_RIGHT
or 7 frames forWALK_TO_RUN_LEFT
.The fix is to set
m_JumpPermitted
totrue
at step 3 above when walk is released. For any other situation, Lara will enterLA_RUN
again from scratch, so the normal lock check will play out.