Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-464: Disabling node reuse during dotnet build and test #105

Merged
merged 7 commits into from
Nov 17, 2022
Merged

OSOE-464: Disabling node reuse during dotnet build and test #105

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
84b9436
Merge remote-tracking branch 'origin/dev' into issue/OSOE-464
Piedone Nov 16, 2022
60c4911
Slapping dotnet node reuse disable on everything
Piedone Nov 16, 2022
9ad852f
Revert "Slapping dotnet node reuse disable on everything"
Piedone Nov 17, 2022
75ab08b
Shutting down the dotnet build servers instead, not to slow down builds
Piedone Nov 17, 2022
eda8a1e
Debug output
Piedone Nov 17, 2022
238d43b
Re-adding missing branch reference
Piedone Nov 17, 2022
13f034c
reset branch selector
sarahelsaig Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/actions/build-dotnet/Build-DotNetSolutionOrProject.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ dotnet build $SolutionOrProject @buildSwitches 2>&1 | ForEach-Object {
if ($noErrors) { Write-Output "::error file=$file,line=$line,col=$column::$message" }
}

# With node reuse, dotnet build spawns processes that while speed up build, they can cause dotnest test and other dotnet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# With node reuse, dotnet build spawns processes that while speed up build, they can cause dotnest test and other dotnet
# With node reuse, dotnet build spawns processes that while speed up build, they can cause dotnet test and other dotnet

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always have to pay attention not to make this typo :D. I'll fix this in dev.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? So it wasn't guerilla marketing?! 😱

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll sneak this change into the .NET SDK.

# tools to randomly hang. So, here we shut down those processes for later actions.
# For details see: https://github.com/Lombiq/UI-Testing-Toolbox/issues/228.
Write-Output "Shutting down .NET build servers."
dotnet build-server shutdown

if ($expectedErrorCodes)
{
$errorCodes = $errorCodes | Sort-Object
Expand Down