OSOE-464: Disabling node reuse during dotnet build and test #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 60c4911.
dministro
reviewed
Nov 17, 2022
| @@ -69,6 +69,12 @@ dotnet build $SolutionOrProject @buildSwitches 2>&1 | ForEach-Object { | |||
| if ($noErrors) { Write-Output "::error file=$file,line=$line,col=$column::$message" } | |||
| } | |||
|
|
|||
| # With node reuse, dotnet build spawns processes that while speed up build, they can cause dotnest test and other dotnet | |||
There was a problem hiding this comment.
Suggested change
| # With node reuse, dotnet build spawns processes that while speed up build, they can cause dotnest test and other dotnet | |
| # With node reuse, dotnet build spawns processes that while speed up build, they can cause dotnet test and other dotnet |
There was a problem hiding this comment.
I always have to pay attention not to make this typo :D. I'll fix this in dev.
There was a problem hiding this comment.
Typo? So it wasn't guerilla marketing?! 😱
There was a problem hiding this comment.
I'll sneak this change into the .NET SDK.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-464