Updated fee logic #4611
Merged
Updated fee logic #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…desktop into 4529-update-native-token-tx-fees
eniolam1000752
suggested changes
Nov 28, 2022
src/modules/transaction/api/index.js
Outdated
| ...transactionObject, | ||
| params: { | ||
| ...transactionObject.params, | ||
| signatures: new Array(numberOfSignatures).fill(0).map(() => Buffer.alloc(64)), |
There was a problem hiding this comment.
Also, I think this should not be done this way only empty signatures should be replaced with an empty buffer, this is because when members are signing, there could be empty signatures(meaning a member is yet to sign) and there could be actual signatures(meaning a member has signed). so in this case I think it can be done like this @ikem-legend
Suggested change
| signatures: new Array(numberOfSignatures).fill(0).map(() => Buffer.alloc(64)), | |
| ...(numberOfSignatures && !transactionObject.params. signatures.length && { signatures: Array(numberOfSignatures).fill(Buffer.alloc(64)) }) , |
There was a problem hiding this comment.
@eniolam1000752 Fixed
eniolam1000752
previously approved these changes
Nov 29, 2022
eniolam1000752
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4529
How was it solved?
By updating the fee calculation logic
How was it tested?