Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt transaction fees based on native token #4529

Closed
Tracked by #4341
soroushm opened this issue Oct 20, 2022 · 3 comments
Closed
Tracked by #4341

Adopt transaction fees based on native token #4529

soroushm opened this issue Oct 20, 2022 · 3 comments

Comments

@soroushm
Copy link
Contributor

soroushm commented Oct 20, 2022

Description

Each application have a native token and transaction fee should calculate based on the current application native token. Also it seems the calculation of transaction fees is wrong especially for a register Multi-signature transaction.

Acceptance Criteria

  • Get the native token id on constant api /api/v3/dpos/constants
  • Validate fee balance based on the native token
  • Fix fee calculation across all types of transactions.
  • Adopt Unit test

Additional Information

@soroushm
Copy link
Contributor Author

@ManuGowda could you please share more information about it with us

@soroushm
Copy link
Contributor Author

@sameersubudhi while you get the information about where native token is going to expose please share it with us

@soroushm
Copy link
Contributor Author

as @sameersubudhi said we need to get nativetokenId from fee apis

The tokenID to be used for the fees should be given by the Fee module. I'll create a separate issue in the repo to deal with it. The PoS module can only give you the governanceTokenID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants