Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to enter Lisk Service URL in network switcher - Closes #3475 #3479

Merged
merged 18 commits into from
Apr 14, 2021

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Apr 12, 2021

What was the problem?

This PR resolves #3475

How was it solved?

  • Used the network selector input for Lisk Service URL.
  • Removed Lisk Core URL from Redux store
  • Updated all logic related to autologin

How was it tested?

  • Manually
  • Updated unit tests

@reyraa reyraa self-assigned this Apr 12, 2021
@reyraa reyraa force-pushed the 3475-refactor-network-switcher branch from 2b32f16 to 6101082 Compare April 12, 2021 14:09
@isalga isalga changed the base branch from feature-sdk-v5 to 3453-fix-unit-tests April 14, 2021 15:41
@reyraa reyraa force-pushed the 3453-fix-unit-tests branch from 65ca867 to a42d09e Compare April 14, 2021 17:17
Base automatically changed from 3453-fix-unit-tests to feature-sdk-v5 April 14, 2021 17:31
@reyraa reyraa merged commit b83898b into feature-sdk-v5 Apr 14, 2021
@reyraa reyraa deleted the 3475-refactor-network-switcher branch April 14, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants