Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to enter Lisk Service URL in network switcher #3475

Closed
reyraa opened this issue Apr 12, 2021 · 0 comments
Closed

Enable users to enter Lisk Service URL in network switcher #3475

reyraa opened this issue Apr 12, 2021 · 0 comments
Assignees
Milestone

Comments

@reyraa
Copy link
Contributor

reyraa commented Apr 12, 2021

Description

Since Lisk Desktop doesn't connect to Lisk Core directly anymore, it doesn't need to receive and save Lisk Core URL. Therefore we should use the custom node input to receive Lisk Service URL.

Motivation

  • Enable users to input their favorite Lisk Service API URL.
  • Remove the redundant complexity of determining Lisk Service URL from Lisk Core URL.

Acceptance Criteria

  • Get rid of getServiceUrl method.
  • Get rid of Lisk Core URL in relevant actions, reducers, middleware and React components.
  • Input Lsik Service URL from the network switcher input.
  • Update Autologin logic to use Lisk Service URL directly.
  • Update relevant unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants