Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add Change Commission command #7757

Merged

Conversation

bobanm
Copy link
Contributor

@bobanm bobanm commented Nov 9, 2022

What was the problem?

This PR resolves #7712

How was it solved?

  1. Implemented changeCommission command according to the LIP
  2. Updated types, schema, DPoS module and constants
  3. Added 5 test cases for verify() and 3 for execute()

How was it tested?

All unit and integration tests are OK 👌🏻

@bobanm bobanm self-assigned this Nov 9, 2022
@bobanm bobanm marked this pull request as ready for review November 9, 2022 20:14
@bobanm bobanm requested review from shuse2 and mosmartin November 9, 2022 20:15
@bobanm bobanm force-pushed the 7712-add-change-commission-command branch from d410693 to 37690dd Compare November 9, 2022 20:26
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! well done 🚀

@bobanm
Copy link
Contributor Author

bobanm commented Nov 10, 2022

Overall LGTM! well done 🚀

Oh really? I thought you will complain about my commit messages 🤣

@shuse2 shuse2 requested review from has5aan and removed request for mosmartin November 10, 2022 10:36
@bobanm bobanm requested a review from shuse2 November 11, 2022 10:57
@shuse2 shuse2 merged commit 9a09fb7 into feature/7622-update-dpos-module Nov 14, 2022
@shuse2 shuse2 deleted the 7712-add-change-commission-command branch November 14, 2022 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants