Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add change commission command to DPoS #7712

Closed
Tracked by #7622
shuse2 opened this issue Nov 1, 2022 · 0 comments
Closed
Tracked by #7622

Add change commission command to DPoS #7712

shuse2 opened this issue Nov 1, 2022 · 0 comments
Assignees
@bobanm
Labels
framework
Milestone
Sprint 82

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Nov 1, 2022

Description

According to the proposed LIP, add change commission command.

Acceptance Criteria

  • Implement logics according to the proposed LIP
  • Add unit test to cover the scenarios
@shuse2 shuse2 moved this to Backlog in Lisk SDK Version 6.0.0 Nov 1, 2022
@bobanm bobanm self-assigned this Nov 4, 2022
@bobanm bobanm changed the title Add change commision command to DPoS Add change commission command to DPoS Nov 7, 2022
@shuse2 shuse2 added this to the Sprint 82 milestone Nov 7, 2022
@bobanm bobanm mentioned this issue Nov 9, 2022
Merged
@shuse2 shuse2 mentioned this issue Nov 10, 2022
Closed
18 tasks
shuse2 pushed a commit that referenced this issue Nov 14, 2022
@bobanm
Add Change Commission command (#7757)
9a09fb7 
### What was the problem?

This PR resolves #7712 

### How was it solved?

1. Implemented `changeCommission` command according to the LIP
2. Updated types, schema, DPoS module and constants
3. Added 5 test cases for `verify()` and 3 for `execute()`

### How was it tested?

All unit and integration tests are OK 👌🏻
@shuse2 shuse2 closed this as completed Nov 14, 2022
Repository owner moved this from Backlog to Done in Lisk SDK Version 6.0.0 Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bobanm bobanm

Labels
framework
Projects
None yet
Milestone
Sprint 82
Development

No branches or pull requests
2 participants
@shuse2 @bobanm