This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix framework integration test - Closes #6640 #6959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
6944-update_genesis_create
to
feature/6554-improve-framework-architecture
January 3, 2022 13:46
shuse2
force-pushed
the
6640-fix_integration_test
branch
from
8705534 to
454e96f
Compare
shuse2
force-pushed
the
6640-fix_integration_test
branch
3 times, most recently
from
4aea45a to
77b1e39
Compare
- Add Integration test back - Fix forever loop for SMT - Fix block generation not executin transaction - Fix dependency injection - Fix token API saving invalid object - Fix genesis asset fixture on test - Fix fork choice time usage - Fix auth module verify to expect no data - Fix reward module to expect no initial value on init - Fix reward module to not check BFT when reward is zero :bug: Fix SMT prefix and loop fix test fixture fix fix processor test
shuse2
force-pushed
the
6640-fix_integration_test
branch
from
3f79fc1 to
65682b3
Compare
shuse2
commented
Jan 15, 2022
| @@ -22,4 +22,5 @@ export const copyBuffer = (value: Buffer): Buffer => { | |||
| }; | |||
|
|
|||
| export const toSMTKey = (value: Buffer): Buffer => | |||
| Buffer.concat([value.slice(0, SMT_PREFIX_SIZE), hash(value.slice(SMT_PREFIX_SIZE))]); | |||
| // First byte is the DB prefix | |||
| Buffer.concat([value.slice(1, SMT_PREFIX_SIZE + 1), hash(value.slice(SMT_PREFIX_SIZE + 1))]); | |||
| while (binaryKey.charAt(h) === currentNodeBinaryKey.charAt(h)) { | ||
| while ( | ||
| binaryKey.length > h && | ||
| currentNodeBinaryKey.length > h && |
There was a problem hiding this comment.
Without this check, it will go into forever loop when all keys are equal
|
|
||
| // First transaction will not have nonce | ||
| try { | ||
| senderAccount = await store.getWithSchema<AuthAccount>( |
There was a problem hiding this comment.
sending first transaction will not have auth data set
| const store = context.getStore(this.id, STORE_PREFIX_AUTH); | ||
| const senderExist = await store.has(transaction.senderAddress); | ||
| if (!senderExist) { | ||
| await store.setWithSchema( |
There was a problem hiding this comment.
Creating initial data was missing
| @@ -54,6 +54,9 @@ export class ReportDelegateMisbehaviorCommand extends BaseCommand { | |||
| this._bftAPI = args.bftAPI; | |||
| this._tokenAPI = args.tokenAPI; | |||
| this._validatorsAPI = args.validatorsAPI; | |||
| } | |||
|
|
|||
| public init(args: { tokenIDDPoS: TokenIDDPoS }) { | |||
There was a problem hiding this comment.
Token ID is not dependency and it's only given in the init step in the module
| db: this._db, | ||
| network: this._network, | ||
| validatorsAPI: this._validatorAPI, | ||
| generatorAddress: Buffer.alloc(0), |
There was a problem hiding this comment.
DB only exist in the init step, so it should be created at the init step
| @@ -439,7 +446,7 @@ export class Consensus { | |||
| { id: block.header.id, height: block.header.height }, | |||
| 'Processing valid block', | |||
| ); | |||
| await this._verify(block); | |||
| block.validate(); | |||
There was a problem hiding this comment.
verification should happen at the later stage
| @@ -100,7 +100,7 @@ export const forkChoice = ( | |||
| // Current time since Lisk Epoch | |||
| const receivedBFTHeader = { | |||
| ...blockHeader.toObject(), | |||
| receivedAt: slots.timeSinceGenesis(), | |||
| receivedAt: Math.floor(Date.now() / 1000), | |||
There was a problem hiding this comment.
at later stage, receivedAt is used as the received time, not time since genesis
| const transactions = | ||
| input.transactions ?? (await this._forgingStrategy.getTransactionsForBlock(blockHeader)); | ||
|
|
||
| blockCtx.setTransactions(transactions); | ||
| for (const tx of transactions) { |
There was a problem hiding this comment.
transaction execution was missing in generator
| await this._stateMachine.executeTransaction(txContext); | ||
| } | ||
|
|
||
| await this._stateMachine.afterExecuteBlock(blockCtx); |
shuse2
force-pushed
the
6640-fix_integration_test
branch
from
5499c5c to
1bbaced
Compare
ishantiw
reviewed
Jan 17, 2022
Comment on lines
127
to
129
| } catch (error) { | ||
| return { status: VerifyStatus.FAIL }; | ||
| return { status: VerifyStatus.FAIL, error: error as Error }; | ||
| } |
There was a problem hiding this comment.
Maybe,
} catch (error: Error) {
return { status: VerifyStatus.FAIL, error };
}There was a problem hiding this comment.
} catch (error: Error) { doesn't work since typescript type it as any
Co-authored-by: !shan <[email protected]>
ishantiw
approved these changes
Jan 19, 2022
…/github.com/LiskHQ/lisk-sdk into 6640-fix_integration_test
shuse2
force-pushed
the
6640-fix_integration_test
branch
from
f20cbee to
b7b95b3
Compare
mitsuaki-u
approved these changes
Jan 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6640, resolves #6961 and resolves #6976
How was it solved?
How was it tested?
Enable integration test