Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

SMT key should not include the database prefix #6961

Closed
shuse2 opened this issue Dec 10, 2021 · 0 comments · Fixed by #6959
Closed

SMT key should not include the database prefix #6961

shuse2 opened this issue Dec 10, 2021 · 0 comments · Fixed by #6959

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Dec 10, 2021

Expected behavior

When calculating the smt key, the input value includes DB key (1byte) in https://github.com/LiskHQ/lisk-sdk/blob/2b91c4fa8a68f6d5a315fb62e91f2672a799b8ba/elements/lisk-chain/src/db_keys.ts

When calculating the SMT key, this bytes needs to be removed as well.

Actual behavior

https://github.com/LiskHQ/lisk-sdk/blob/2b91c4fa8a68f6d5a315fb62e91f2672a799b8ba/elements/lisk-chain/src/state_store/utils.ts#L24-L25

Steps to reproduce

console log the input of this function and check if the first byte is db key, or module id

Which version(s) does this affect? (Environment, OS, etc...)

feature/6554-improve-framework-architecture

@shuse2 shuse2 moved this to Backlog in Lisk SDK Version 6.0.0 Jan 7, 2022
@shuse2 shuse2 self-assigned this Jan 12, 2022
@shuse2 shuse2 added this to the Sprint 60 milestone Jan 14, 2022
@shuse2 shuse2 moved this from Backlog to In Progress in Lisk SDK Version 6.0.0 Jan 14, 2022
@shuse2 shuse2 linked a pull request Jan 14, 2022 that will close this issue
@milenagojkovic milenagojkovic modified the milestones: Sprint 60, Sprint 61 Jan 15, 2022
@shuse2 shuse2 moved this from In Progress to Pending Review in Lisk SDK Version 6.0.0 Jan 15, 2022
@shuse2 shuse2 closed this as completed Jan 19, 2022
Repository owner moved this from Pending Review to Done in Lisk SDK Version 6.0.0 Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants