Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Re-enable e2e tests for features already working in React - Closes #565 #577

Merged
merged 20 commits into from
Aug 17, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Aug 8, 2017

Closes #565

@reyraa
Copy link
Contributor

reyraa commented Aug 16, 2017

There's 3 thoughts about current setup of e2e tests:

  • They don't meet out eslint standard. which we'll cover with Jenkins doesn't fail if there are eslint errors in tests #548
  • It depicts active peer as Offline in all the tests. even though it makes all the Api calls successfully.
  • we always have to fun e2e-test-setup.sh before running e2e-test, why not merging these together?
  • Some of tests are written based on classnames belonging to the theme framework and thus vulnerable to theme changes.

Copy link
Contributor

@reyraa reyraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vit. The issue with Testnet is solved now.

@slaweet slaweet merged commit 9ebf3b7 into development Aug 17, 2017
@slaweet slaweet deleted the 565-re-enable-e2e-tests branch August 17, 2017 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants