Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Jenkins doesn't fail if there are eslint errors in tests #548

Closed
slaweet opened this issue Aug 2, 2017 · 0 comments
Closed

Jenkins doesn't fail if there are eslint errors in tests #548

slaweet opened this issue Aug 2, 2017 · 0 comments
Assignees

Comments

@slaweet
Copy link
Contributor

slaweet commented Aug 2, 2017

Expected behaviour

Jenkins should fail if there are some eslint errors in any js file
That includes:

  • unit tests
  • e2e tests.
  • electron js files.

Actual behaviour

Jenkins only fails of there are eslint errors in source code, not in tests, so these errors made it to development:

ERROR in ./src/actions/toaster.test.js
ESLintError: 
�/home/lisk/jenkins/workspace/Nano-Pipeline_PR-528-FIT557NSAL6UDXDBXECWKK7CZ7AOPHW3SVG5CBQI5YI6GO5HABMA/src/actions/toaster.test.js�
  �11:55�  �error�  Block must not be padded by blank lines  �padded-blocks�

����� 1 problem (1 error, 0 warnings)
��

ERROR in ./src/components/passphrase/passphraseGenerator.test.js
ESLintError: 
�/home/lisk/jenkins/workspace/Nano-Pipeline_PR-528-FIT557NSAL6UDXDBXECWKK7CZ7AOPHW3SVG5CBQI5YI6GO5HABMA/src/components/passphrase/passphraseGenerator.test.js�
  �5:10�  �error�  'mount' is defined but never used  �no-unused-vars�

����� 1 problem (1 error, 0 warnings)
��

ERROR in ./src/utils/passphrase.test.js
ESLintError: 
�/home/lisk/jenkins/workspace/Nano-Pipeline_PR-528-FIT557NSAL6UDXDBXECWKK7CZ7AOPHW3SVG5CBQI5YI6GO5HABMA/src/utils/passphrase.test.js�
  �2:10�  �error�  'spy' is defined but never used  �no-unused-vars�

����� 1 problem (1 error, 0 warnings)
��

ERROR in ./src/components/voting/votingHeader.test.js
ESLintError: 
�/home/lisk/jenkins/workspace/Nano-Pipeline_PR-528-FIT557NSAL6UDXDBXECWKK7CZ7AOPHW3SVG5CBQI5YI6GO5HABMA/src/components/voting/votingHeader.test.js�
  �44:55�  �error�  Missing semicolon  �semi�

����� 1 problem (1 error, 0 warnings)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant