Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Fix coverage reports - Closes #276 #537

Merged
merged 4 commits into from
Jul 31, 2017
Merged

Fix coverage reports - Closes #276 #537

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fff6e2
Send coverage to coveralls by separate command
slaweet Jul 31, 2017
1b5acd7
Make coveralls submission independent of Chrome version
slaweet Jul 31, 2017
2051837
Removed no longer used 'karma-coveralls' from dependencies
slaweet Jul 31, 2017
41e3c6c
Add comment to coveralls submission
slaweet Jul 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ node('lisk-nano-01'){
# Run test
cd $WORKSPACE
npm run test
cat coverage/*/lcov.info | coveralls -v
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a new line and a comment that we are submitting coverage here.

'''
} catch (err) {
currentBuild.result = 'FAILURE'
Expand Down
2 changes: 1 addition & 1 deletion karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = function (config) {
preprocessors: {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the jenkins constant, and karma-coveralls(maybe, depends on the way lcov gets made...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onJenkins is still used to decide whether generate html or lcov report.
I removed the karma-coveralls, dependency.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok great :)

[fileGlob]: ['webpack'],
},
reporters: ['coverage', 'mocha'].concat(onJenkins ? ['coveralls'] : []),
reporters: ['coverage', 'mocha'],
coverageReporter: {
reporters: [
{
Expand Down