This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Fix coverage reports - Closes #276 #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
276-fix-coveralls
branch
from
3823681 to
d9057a9
Compare
slaweet
force-pushed
the
276-fix-coveralls
branch
from
d9057a9 to
1fff6e2
Compare
Isabello
suggested changes
Jul 31, 2017
| @@ -14,7 +14,7 @@ module.exports = function (config) { | |||
| preprocessors: { | |||
There was a problem hiding this comment.
You can remove the jenkins constant, and karma-coveralls(maybe, depends on the way lcov gets made...)
There was a problem hiding this comment.
onJenkins is still used to decide whether generate html or lcov report.
I removed the karma-coveralls, dependency.
Jenkinsfile
Outdated
| @@ -76,6 +76,7 @@ node('lisk-nano-01'){ | |||
| # Run test | |||
| cd $WORKSPACE | |||
| npm run test | |||
| cat coverage/*/lcov.info | coveralls -v | |||
There was a problem hiding this comment.
add a new line and a comment that we are submitting coverage here.
Isabello
approved these changes
Jul 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #276