Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Refactor tabular data to use classification targets handling #1114

Merged
merged 6 commits into from
Jan 14, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jan 13, 2022

What does this PR do?

Refactors tabular classification data to use the classification targets handling. Also includes some other fixes.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris changed the title Refactor tabular data Refactor tabular data to use classification targets handling Jan 13, 2022
@ethanwharris ethanwharris marked this pull request as ready for review January 13, 2022 21:27
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #1114 (b5ae628) into master (127b7c0) will decrease coverage by 0.92%.
The diff coverage is 93.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
- Coverage   88.49%   87.57%   -0.93%     
==========================================
  Files         284      286       +2     
  Lines       12891    12938      +47     
==========================================
- Hits        11408    11330      -78     
- Misses       1483     1608     +125     
Flag Coverage Δ
unittests 87.57% <93.61%> (-0.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/classification/cli.py 100.00% <ø> (ø)
flash/tabular/classification/model.py 96.66% <ø> (ø)
flash/tabular/classification/utils.py 97.29% <ø> (-0.14%) ⬇️
flash/tabular/regression/cli.py 100.00% <ø> (ø)
flash/tabular/regression/model.py 100.00% <ø> (ø)
flash/tabular/regression/input.py 90.00% <90.00%> (ø)
flash/tabular/classification/input.py 92.00% <92.00%> (ø)
flash/tabular/classification/data.py 95.83% <95.45%> (-4.17%) ⬇️
flash/tabular/regression/data.py 95.83% <95.45%> (-4.17%) ⬇️
flash/tabular/data.py 100.00% <100.00%> (+1.88%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 127b7c0...b5ae628. Read the comment docs.

@ethanwharris ethanwharris merged commit 428cdb8 into master Jan 14, 2022
@ethanwharris ethanwharris deleted the feature/refactor_tabular_data branch January 14, 2022 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant