Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serialized checkpoint loading #9605

Merged
merged 17 commits into from
Oct 20, 2021

Conversation

jjenniferdai
Copy link
Contributor

@jjenniferdai jjenniferdai commented Sep 20, 2021

What does this PR do?

Fixes #9406

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added checkpointing Related to checkpointing distributed Generic distributed-related topic feature Is an improvement or enhancement labels Sep 24, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 24, 2021
@jjenniferdai jjenniferdai changed the title [wip][redo 9585] Support serialized checkpoint loading Support serialized checkpoint loading Sep 24, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
@mergify mergify bot added the has conflicts label Oct 6, 2021
@tchaton tchaton self-requested a review October 13, 2021 17:51
@mergify mergify bot removed the has conflicts label Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #9605 (701fb6a) into master (6feda08) will decrease coverage by 4%.
The diff coverage is 38%.

@@           Coverage Diff           @@
##           master   #9605    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15805   15824    +19     
=======================================
- Hits        14648   14030   -618     
- Misses       1157    1794   +637     

@mergify mergify bot removed the has conflicts label Oct 14, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 18, 2021
@awaelchli awaelchli enabled auto-merge (squash) October 18, 2021 22:59
@awaelchli awaelchli merged commit f0e6f1b into Lightning-AI:master Oct 20, 2021
jjenniferdai added a commit that referenced this pull request Oct 20, 2021
awaelchli pushed a commit that referenced this pull request Oct 21, 2021
awaelchli added a commit that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing distributed Generic distributed-related topic feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support serialized checkpoint loading
5 participants