-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support serialized checkpoint loading #9605
Merged
awaelchli
merged 17 commits into
Lightning-AI:master
from
jjenniferdai:serialize-cp-loading-2
Oct 20, 2021
Merged
Support serialized checkpoint loading #9605
awaelchli
merged 17 commits into
Lightning-AI:master
from
jjenniferdai:serialize-cp-loading-2
Oct 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
12 tasks
tchaton
reviewed
Sep 21, 2021
ananthsub
reviewed
Sep 24, 2021
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
awaelchli
added
checkpointing
Related to checkpointing
distributed
Generic distributed-related topic
feature
Is an improvement or enhancement
labels
Sep 24, 2021
jjenniferdai
changed the title
[wip][redo 9585] Support serialized checkpoint loading
Support serialized checkpoint loading
Sep 24, 2021
jjenniferdai
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren and
williamFalcon
as code owners
September 27, 2021 18:34
awaelchli
reviewed
Sep 30, 2021
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrian Wälchli <[email protected]>
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #9605 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 179 179
Lines 15805 15824 +19
=======================================
- Hits 14648 14030 -618
- Misses 1157 1794 +637 |
tchaton
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
ananthsub
approved these changes
Oct 18, 2021
awaelchli
approved these changes
Oct 18, 2021
Borda
reviewed
Oct 19, 2021
jjenniferdai
added a commit
that referenced
this pull request
Oct 20, 2021
This reverts commit f0e6f1b.
awaelchli
pushed a commit
that referenced
this pull request
Oct 21, 2021
awaelchli
added a commit
that referenced
this pull request
Oct 22, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
checkpointing
Related to checkpointing
distributed
Generic distributed-related topic
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9406
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃