Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support serialized checkpoint loading" #10057

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

jjenniferdai
Copy link
Contributor

@jjenniferdai jjenniferdai commented Oct 20, 2021

Reverts #9605

temp revert as I think about how to best fix this with #10061 :
#9605 with #9413 causes serialized loading TTPs' validate/test/predict() to use resume_from_checkpoint instead of ckpt_path:

  1. Fix restoring training state during trainer.fit only #9413 adds resume_start call for all states instead of fit only, after trainer._load_checkpoint_weights() call with ckpt_path
  2. resume_start with resume_from_checkpoint path --> Support serialized checkpoint loading #9605 serialized TTP load_checkpoint loads model state instead of loading ckpt file only

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #10057 (0e6a176) into master (5b30a65) will decrease coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #10057   +/-   ##
=======================================
- Coverage      93%      93%   -0%     
=======================================
  Files         180      180           
  Lines       15908    15889   -19     
=======================================
- Hits        14722    14703   -19     
  Misses       1186     1186           

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 20, 2021
@awaelchli awaelchli merged commit 2d9db21 into master Oct 21, 2021
@awaelchli awaelchli deleted the revert-9605-serialize-cp-loading-2 branch October 21, 2021 00:51
awaelchli added a commit that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants