-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow one value for each plugin type in plugins
flag
#12083
Conversation
plugins
flag
@four4fish How is this a breaking change? It was never supported. |
@kaushikb11 If user set two checkpointIO in plugins before, we used the later one instead of throw exception. Does this considered breaking change? |
IMO, we should throw exception for this case as well. |
Checkpoint io duplication check is included in this PR. Just a example to explain why this could be a breaking change |
a90a8a4
to
48d1550
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reviewing the PR, also found this malformatted error message:
pytorch_lightning.utilities.exceptions.MisconfigurationException: You have passed Trainer(strategy=ddp) and you can only specify one strategy, but you have passed <pytorch_lightning.plugins.training_type.ddp_spawn.DDPSpawnPlugin object at 0x7fc2bb458310> as a plugin.
it can be triggered by
Trainer(
strategy="ddp",
plugins=[DDPSpawnPlugin()]
)
for example. Would be nice follow up :)
973f7b7
to
b5a6d18
Compare
Co-authored-by: Adrian Wälchli <[email protected]>
c90022f
to
1fa65ea
Compare
for more information, see https://pre-commit.ci
Co-authored-by: ananthsub <[email protected]>
What does this PR do?
Fixes #11449 follow up item : check there is only 1 instance of each type at most in plugin flag
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃