Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow one value for each plugin type in plugins flag #12083

Merged
merged 9 commits into from
Mar 11, 2022

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Feb 24, 2022

What does this PR do?

Fixes #11449 follow up item : check there is only 1 instance of each type at most in plugin flag

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@four4fish four4fish added this to the 1.6 milestone Feb 24, 2022
@four4fish four4fish changed the title Only allow one value for one plugin type in flag Only allow one value for each plugin type in plugins flag Feb 24, 2022
@kaushikb11
Copy link
Contributor

@four4fish How is this a breaking change? It was never supported.

@four4fish
Copy link
Contributor Author

@four4fish How is this a breaking change? It was never supported.

@kaushikb11 If user set two checkpointIO in plugins before, we used the later one instead of throw exception. Does this considered breaking change?

@kaushikb11
Copy link
Contributor

@kaushikb11 If user set two checkpointIO in plugins before, we used the later one instead of throw exception. Does this considered breaking change?

IMO, we should throw exception for this case as well.

@four4fish
Copy link
Contributor Author

@kaushikb11 If user set two checkpointIO in plugins before, we used the later one instead of throw exception. Does this considered breaking change?

IMO, we should throw exception for this case as well.

Checkpoint io duplication check is included in this PR. Just a example to explain why this could be a breaking change

@mergify mergify bot added the has conflicts label Mar 1, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reviewing the PR, also found this malformatted error message:

pytorch_lightning.utilities.exceptions.MisconfigurationException: You have passed Trainer(strategy=ddp) and you can only specify one strategy, but you have passed <pytorch_lightning.plugins.training_type.ddp_spawn.DDPSpawnPlugin object at 0x7fc2bb458310> as a plugin.

it can be triggered by

Trainer(
        strategy="ddp",
        plugins=[DDPSpawnPlugin()]
)

for example. Would be nice follow up :)

CHANGELOG.md Outdated Show resolved Hide resolved
@four4fish four4fish force-pushed the accl_conn/one_plugin branch from 973f7b7 to b5a6d18 Compare March 4, 2022 19:05
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Mar 4, 2022
@four4fish four4fish force-pushed the accl_conn/one_plugin branch from c90022f to 1fa65ea Compare March 4, 2022 23:33
@tchaton tchaton enabled auto-merge (squash) March 5, 2022 10:32
@tchaton tchaton merged commit 4d74f37 into Lightning-AI:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change plugin ready PRs ready to be merged trainer: connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite Accelerator_connector and follow up tasks
7 participants