Skip to content

Commit

Permalink
adress comments
Browse files Browse the repository at this point in the history
  • Loading branch information
four4fish committed Feb 28, 2022
1 parent e8418c2 commit a90a8a4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pytorch_lightning/trainer/connectors/accelerator_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,17 +304,17 @@ def _check_config_and_set_final_flags(
f"Passing {plugin} `strategy` to the `plugins` flag in Trainer has been deprecated"
f" in v1.5 and will be removed in v1.7. Use `Trainer(strategy={plugin})` instead."
)
plugins_flags_types_list.append("Strategy")
plugins_flags_types_list.append(Strategy.__name__)

elif isinstance(plugin, PrecisionPlugin):
self._precision_plugin_flag = plugin
plugins_flags_types_list.append("PrecisionPlugin")
plugins_flags_types_list.append(PrecisionPlugin.__name__)
elif isinstance(plugin, CheckpointIO):
self.checkpoint_io = plugin
plugins_flags_types_list.append("CheckpointIO")
plugins_flags_types_list.append(CheckpointIO.__name__)
elif isinstance(plugin, ClusterEnvironment):
self._cluster_environment_flag = plugin
plugins_flags_types_list.append("ClusterEnvironment")
plugins_flags_types_list.append(ClusterEnvironment.__name__)
else:
raise MisconfigurationException(
f"Found invalid type for plugin {plugin}. Expected PrecisionPlugin, "
Expand Down

0 comments on commit a90a8a4

Please sign in to comment.