Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LiteOptimizer signature after optimizer changes in TrainingTypePlugin #10708

Merged
merged 4 commits into from
Nov 30, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 23, 2021

What does this PR do?

Follow-up to #10596
Resolves a TODO in #10596

The LiteOptimizer no longer takes the accelerator as input and instead takes the Strategy.
The accelerator is not needed, since the optimizer step is now owned by the Strategy.

Should be merged after #10596

Does your PR introduce any breaking changes? If yes, please list them.

None. LiteOptimizer is not a public API

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @justusschock @awaelchli @akihironitta @carmocca

@awaelchli awaelchli changed the title update Update LiteOptimizer signature after optimizer changes in TrainingTypePlugin Nov 23, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli added fabric lightning.fabric.Fabric refactor labels Nov 30, 2021
@awaelchli awaelchli added this to the 1.6 milestone Nov 30, 2021
@awaelchli awaelchli marked this pull request as ready for review November 30, 2021 09:02
@awaelchli awaelchli requested a review from carmocca as a code owner November 30, 2021 09:02
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/lite/wrappers.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 30, 2021
@awaelchli awaelchli enabled auto-merge (squash) November 30, 2021 12:45
@awaelchli awaelchli merged commit a81accb into master Nov 30, 2021
@awaelchli awaelchli deleted the refactor/lite/lite-optimizer branch November 30, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants