-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2/n Move Precision Plugin into strategy - move optimizer related logics #10596
Conversation
19530c3
to
115a2b4
Compare
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from existing open comments, LGTM, nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov Report
@@ Coverage Diff @@
## master #10596 +/- ##
========================================
- Coverage 90% 88% -2%
========================================
Files 177 177
Lines 16505 16509 +4
========================================
- Hits 14920 14535 -385
- Misses 1585 1974 +389 |
What does this PR do?
1/n Move Precision Plugin into Strategy and update references
2/n Move optimizer, lr to Strategy
3/n Simplify and reduce hooks and redundancies
Fixes #7324 which is part of #10416
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃