Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove model_connector.py #10111

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Conversation

daniellepintz
Copy link
Contributor

What does this PR do?

Fixes #10110

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title says "Deprecate" but there's nothing being deprecated here

pytorch_lightning/trainer/connectors/data_connector.py Outdated Show resolved Hide resolved
@daniellepintz daniellepintz changed the title Deprecate model_connector.py Remove model_connector.py Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #10111 (03b5b5e) into master (34d5980) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #10111    +/-   ##
========================================
- Coverage      93%      89%    -4%     
========================================
  Files         181      180     -1     
  Lines       16150    16145     -5     
========================================
- Hits        14939    14318   -621     
- Misses       1211     1827   +616     

@mergify mergify bot removed the has conflicts label Oct 26, 2021
@mergify mergify bot added the ready PRs ready to be merged label Oct 26, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 26, 2021
@awaelchli awaelchli merged commit a5235d5 into Lightning-AI:master Oct 26, 2021
@daniellepintz daniellepintz deleted the model_con branch October 26, 2021 21:31
ninginthecloud pushed a commit to ninginthecloud/pytorch-lightning that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove model_connector.py
4 participants