You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
model_connector.py has only one function copy_trainer_model_properties which is used in one place, data_connector.py. Let's move copy_trainer_model_properties directly to data_connector.py.
Yup, I'm doing the moving first in one PR and then we can do simplification PRs afterwards, since if we did them in the same PR it would be hard to review
Proposed refactoring or deprecation
model_connector.py
has only one functioncopy_trainer_model_properties
which is used in one place,data_connector.py
. Let's movecopy_trainer_model_properties
directly todata_connector.py
.Motivation
We are auditing the connectors in the Architecture doc (https://docs.google.com/document/d/1xHU7-iQSpp9KJTjI3As2EM0mfNHHr37WZYpDpwLkivA/edit?pli=1#heading=h.rjokms600dhn). We can simplify things by removing
model_connector.py
and moving the function todata_connector.py
.The text was updated successfully, but these errors were encountered: