Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: TensorParallel with new strategy #1421

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: TensorParallel with new strategy #1421

wants to merge 1 commit into from

Conversation

awaelchli
Copy link
Contributor

Shows how the new ModelParallelStrategy could be applied in generate/tp.py.

Some caveats:

  • Need to apply quantization in the parallelize function (to be done)
  • DTensors don't work with torch.inference_mode

There is room to apply more parallelism. For example, the RMSNorm could leverage SequenceParallel.

@awaelchli awaelchli mentioned this pull request May 15, 2024
Merged
@rasbt rasbt mentioned this pull request Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasbt rasbt Awaiting requested review from rasbt rasbt will be requested when the pull request is marked ready for review rasbt is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga will be requested when the pull request is marked ready for review lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@awaelchli