Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate data load for feature branches #763

Merged
merged 15 commits into from
Jan 18, 2019
Merged

Automate data load for feature branches #763

merged 15 commits into from
Jan 18, 2019

Conversation

rstorey
Copy link
Member

@rstorey rstorey commented Jan 15, 2019

Refs #765

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 69.456% when pulling 9cbec18 on automate-data-load into 66f07e5 on master.

@coveralls
Copy link

coveralls commented Jan 15, 2019

Coverage Status

Coverage remained the same at 69.456% when pulling 32d42b3 on automate-data-load into b2eb06d on master.

@rstorey rstorey changed the title WIP: Automate data load Automate data load Jan 17, 2019
@rstorey rstorey requested a review from acdha January 17, 2019 16:09
@rstorey rstorey changed the title Automate data load Automate data load for feature branches Jan 17, 2019
@rstorey rstorey force-pushed the automate-data-load branch 2 times, most recently from 95aa8e1 to eeb0525 Compare January 17, 2019 16:27
@rstorey rstorey force-pushed the automate-data-load branch from db13daf to 06ec648 Compare January 17, 2019 16:39
@rstorey
Copy link
Member Author

rstorey commented Jan 17, 2019

I'm done with this for now, unless there are changes you'd like made @acdha The most recent test was a success

Copy link
Member

@acdha acdha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes for bastion 1/2 necessary now that there's a the dataloadhost declaration? I'm wondering whether we should just have that confined to that purpose, set InstanceInitiatedShutdownBehavior=terminate, and add a shutdown -h now call to the end of the user-data script.

@rstorey
Copy link
Member Author

rstorey commented Jan 17, 2019

Are the changes for bastion 1/2 necessary now that there's a the dataloadhost declaration? I'm wondering whether we should just have that confined to that purpose, set InstanceInitiatedShutdownBehavior=terminate, and add a shutdown -h now call to the end of the user-data script.

I still use the bastion host template for loading DB dumps to dev / test / stage and get the DB dump from prod. It's not needed for loading data to feature branch deployments. But the changes I made there make it much simpler to dump or restore in the four main environments. I will add the shutdown stuff.

@rstorey
Copy link
Member Author

rstorey commented Jan 18, 2019

I need to merge this one before we can use the feature branch deployment. I'm happy to make changes even after the stuff is merged.

@rstorey rstorey merged commit 3d48d07 into master Jan 18, 2019
@rstorey rstorey deleted the automate-data-load branch January 29, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants