3.10.5 #2
Closed
3.10.5 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[fuchsia] Feedback filing migration
Roll Dart SDK from 267a5fa8c8b9 to 6ac8d3ad105f (3 revisions)
Add initial docs for the engine build definition.
… (#40761) Use new SkImages namespace instead of legacy SkImage static functions
[Impeller] Un-ifdef vulkan code in impellerc
Bump github/codeql-action from 2.2.7 to 2.2.8
…tests. (#40770) [Impeller] backfilled golden tests from playground tests in aiks_unittests.
[Impeller] use native decal on metal and Vulkan backend
`ui_web` library
… core (#40801)" (#40811) This reverts commit 5e7e153.
Roll Skia from 9b2e538f1367 to f6c1eefd4600 (4 revisions)
Re-enable LTO and roll buildroot to enable `sINLINING_LIMIT`
[Impeller] Use Vulkan by default
[Impeller] Skip TextRotated golden test.
[Impeller] Reland move more files to core.
…. (#40819) Roll Fuchsia Mac SDK from oI2Ff-WGV-Y2oa3CD... to kiAbXJ_MIn6CAC9-C...
Roll Skia from f6c1eefd4600 to 38cbca906011 (2 revisions)
This reverts commit a6421ed. Reverting for flutter/flutter#123859
Roll Skia from 38cbca906011 to 5f965db93be3 (7 revisions)
Complete the update semantics embedder API migration
Roll Skia from 5f965db93be3 to 2b86c6d364d0 (4 revisions)
This PR makes view ID signed from unsigned int64. Initially, I made view IDs unsigned because they were opaque anyway. As I'm working deeper into multiview, I found some issues that made me think signed is better: * Unsigned integers are worse * Sometimes you want negative values to represent special values. * Unsigned integers are dangerous (if compared with signed ones by mistake.) * Unsigned integers are not needed * We're very unlikely to reach that big anyway. * Almost all other languages support only signed integers. * Also JavaScript only supports up to 51 bits of integer. Therefore I think it's better to change them to signed int64, especially before these APIs are widely used by developers. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I signed the [CLA]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
…overflows. (#40806) [Impeller] Declare gradient shader inputs as high precision to avoid overflows.
Fix pretty list printer to handle nulls
Reverts flutter/engine#39958 Failing the roll to the framework starting with flutter/flutter#123893 One example: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20dart_plugin_registry_test/21819/overview
DenisovAV
pushed a commit
to DenisovAV/flutter-tvos-engine
that referenced
this pull request
Feb 8, 2024
…visions) (#43457)" (#43466) This reverts commit a109e0b as it breaks flutter framework tests during subsequent roll. From flutter/flutter#130138: _TypeError: (#0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53)) ``` #0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53) LibertyGlobal#1 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) LibertyGlobal#2 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:444:23) LibertyGlobal#3 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) LibertyGlobal#4 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:419:54) LibertyGlobal#5 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) LibertyGlobal#6 ListIterable.forEach (dart:_internal/iterable.dart:39:13) LibertyGlobal#7 _ProgramInfoBuilder.build (package:vm_snapshot_analysis/v8_profile.dart:338:16) LibertyGlobal#8 toProgramInfo (package:vm_snapshot_analysis/v8_profile.dart:282:8) LibertyGlobal#9 _treemapFromSnapshot (package:vm_snapshot_analysis/treemap.dart:158:27) LibertyGlobal#10 treemapFromJson (package:vm_snapshot_analysis/treemap.dart:85:5) LibertyGlobal#11 SizeAnalyzer.analyzeZipSizeAndAotSnapshot (package:flutter_tools/src/base/analyze_size.dart:123:59) LibertyGlobal#12 AndroidGradleBuilder._performCodeSizeAnalysis (package:flutter_tools/src/android/gradle.dart:623:60) LibertyGlobal#13 AndroidGradleBuilder.buildGradleApp (package:flutter_tools/src/android/gradle.dart:604:15) <asynchronous suspension> LibertyGlobal#14 AndroidGradleBuilder.buildApk (package:flutter_tools/src/android/gradle.dart:242:5) <asynchronous suspension> LibertyGlobal#15 BuildApkCommand.runCommand (package:flutter_tools/src/commands/build_apk.dart:116:5) <asynchronous suspension> LibertyGlobal#16 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27) <asynchronous suspension> LibertyGlobal#17 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19) <asynchronous suspension> LibertyGlobal#18 CommandRunner.runCommand (package:args/command_runner.dart:212:13) <asynchronous suspension> ```
DenisovAV
pushed a commit
to DenisovAV/flutter-tvos-engine
that referenced
this pull request
May 5, 2024
…#47360) This relands flutter/engine#43620 with a fix for nested tappable nodes. The first PR introduced this regression: flutter/flutter#134842. This PR includes the original PR and a fix for the regression. The fix is to call `stopPropagation` on the "click" event so that it is not handled by the ancestor if the child has already decided to send a `SemanticsAction.tap` to the framework. This ensures that there cannot be more than one `SemanticsAction.tap` sent to the framework. Fixes flutter/flutter#134842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.