Calculate instance values for com.typemytype.robofont.italicSlantOffset #59 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a mutator for values in com.typemytype.robofont.italicSlantOffset. Calculate the value when making an instance UFO. + getItalicSlantOffsetMutator() collects the values from the relevant sources. + only add the value to the instance UFO lib if it is not zero. Not entirely sure about this, but it seems cleaner? + Lib values added to the ds5 test fonts.
All lib keys added to self.libKeysForProcessing will be calculated. self.italicSlantOffsetLibKey is added by default, but the operator's operator could add keys before generating the instances. + Currently this assumes default 0 for such a value if there is no entry in the lib. That's probably something to reconsider. It's hard to do any checks on these values because the code doesn't know them.
Add debug output for libMath processing. Add testLibMathKey to the tests.
|
This will look for lib keys in |
If we can't find any lib key values in any of the sources: don't make a mutator. Also, if one source does not have a particular libkey, ignore the source. Don't make assumptions about the value. (was: assume 0) Remove a print.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a mutator for values in com.typemytype.robofont.italicSlantOffset. Calculate the value when making an instance UFO.