Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy com.typemytype.robofont.italicSlantOffset value #59

Closed
LettError opened this issue May 28, 2024 · 3 comments
Closed

Copy com.typemytype.robofont.italicSlantOffset value #59

LettError opened this issue May 28, 2024 · 3 comments
Assignees
@LettError

Comments

@LettError
Copy link
Owner

If the sources have an entry for com.typemytype.robofont.italicSlantOffset, it would be convenient to copy this value to instances.

Arguments:

  • the glyphs will be drawn with this offset.
  • RF will use this value and compensate for it when generating binaries.
  • I don't think the value needs to be interpolated.

Code would need to check specifically if the sources for the discrete location of the instance have the value set.
@LettError LettError self-assigned this May 28, 2024
@typemytype
Copy link
Collaborator

+1

the fallback value is 0 if that lib key is not available

@LettError
Copy link
Owner Author

This value relates to glyph geometry. Therefore it would be eligible for interpolation.

LettError added a commit that referenced this issue Jun 16, 2024
@LettError
WIP for isse #59
80d48f6 
Create a mutator for values in com.typemytype.robofont.italicSlantOffset.
Calculate the value when making an instance UFO.
+ getItalicSlantOffsetMutator() collects the values from the relevant sources.
+ only add the value to the instance UFO lib if it is not zero. Not entirely sure about this, but it seems cleaner?
+ Lib values added to the ds5 test fonts.
@LettError
Copy link
Owner Author

#61

LettError added a commit that referenced this issue Aug 14, 2024
@LettError
Merge pull request #61 from LettError/italicslantoffset
085c892 
Calculate instance values for com.typemytype.robofont.italicSlantOffset  #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LettError LettError

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@typemytype @LettError