Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downvote on post in postview doing a upvote #893

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix downvote on post in postview doing a upvote #893

merged 1 commit into from
Jun 27, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jun 27, 2023

Fixes #891

studio64_q84HUefDPk.mp4

pure-bliss
pure-bliss approved these changes Jun 27, 2023
View reviewed changes
Copy link

@pure-bliss pure-bliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely minor, and shouldn't be this PR-s scope: CreatePostLike sounds too positive, and can be misleading. Might be worth to implement CreatePostUpvote and CreatePostDownvote that don't need VoteType parameter at one point

@MV-GH
Copy link
Collaborator Author

MV-GH commented Jun 27, 2023 •
edited
Loading

CreatePostLike is a autogenerated type generated from the Lemmy rust backend. We don't modify those here, but you can make a issue at lemmy to refactor those types.

@twizmwazin twizmwazin merged commit 0934e39 into LemmyNet:main Jun 27, 2023
@MV-GH MV-GH deleted the bug/891 branch September 20, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pure-bliss pure-bliss pure-bliss approved these changes

@dessalines dessalines Awaiting requested review from dessalines dessalines is a code owner

@twizmwazin twizmwazin Awaiting requested review from twizmwazin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downvoting a post actually upvotes it
3 participants
@MV-GH @pure-bliss @twizmwazin