Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downvoting a post actually upvotes it #891

Closed
pure-bliss opened this issue Jun 27, 2023 · 6 comments · Fixed by #893
Closed

Downvoting a post actually upvotes it #891

pure-bliss opened this issue Jun 27, 2023 · 6 comments · Fixed by #893
Labels
bug Something isn't working

Comments

@pure-bliss
Copy link

Jerboa Version
0.0.35

Android version + phone
13, Xiaomi Redmi

Describe the bug
Downvoting a post actually upvotes it

To Reproduce
Steps to reproduce the behavior:

  1. Go to any lemmy instance, find a post, open it on jerboa, and web browser
  2. Tap on downvote
  3. Refresh post in browser / on phone
  4. Post is upvoted instead of downvoted

How does these PRs actually pass reviews? Do developers actually read it? jerboa is not trustable, this way anything goes

@pure-bliss pure-bliss added the bug Something isn't working label Jun 27, 2023
@MV-GH
Copy link
Collaborator

MV-GH commented Jun 27, 2023

Screenrecorder-2023-06-27-20-07-14-615.mp4

Can't reproduce. If you think you can do a better job, contributions are always welcome 🤗. Keep in mind this a alpha build, bound to have bugs

@nahwneeth
Copy link
Contributor

@pure-bliss
Copy link
Author

Screenrecorder-2023-06-27-20-19-29-259.mp4

@MV-GH
Copy link
Collaborator

MV-GH commented Jun 27, 2023

Can't reproduce

I think the post has to be opened.

https://github.com/dessalines/jerboa/blob/0557d7fe2264fb7bb2d4d057c1b476879cbc0c68/app/src/main/java/com/jerboa/ui/components/post/PostActivity.kt#L335

Ah i see, simple fix.

@MV-GH
Copy link
Collaborator

MV-GH commented Jun 27, 2023

That code is from 05fda4a, and did not go through any PR as dessalines was the sole contributor at the time.

@pure-bliss
Copy link
Author

That code is from 05fda4a, and did not go through any PR as dessalines was the sole contributor at the time.

Blame shows this diff: 7d9c5a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants