-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "Posta in arrivo" with "Notifiche" #826
Conversation
This avoid issues with the label in the bottom menu bar
I don't think that using an english word makes much sense for an italian translation. Wouldn't "messaggi" or "notifiche" be better? |
"Posta" would be good enough |
TBH I'm not proud of this change. It feels like a workaround to solve a problem that should be fixed differently (via proper hyphenation, for example). So do with this what you will. I'm not a fan of Posta or Messaggi since one is a bit vague and the other a bit misleading. But I understand the criticism towards an English term, and in that case maybe the best option is wrapping words properly in the UI (if feasible, I'm not an Android dev). |
What you mean wrapping the words? Isn't doing that already, if its too long it should put the text below it see #818 |
If it's necessary to have a single-word replacement I think "notifiche" is the most appropriate solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notifiche
seems like a better fit then
Really sorry everyone, I just found a few minutes now to update the PR and I'm on GitHub for Android on top of that. I hope the diff looks good now. @dessalines I've rebased my branch and at the pace development is happening there's probably a bunch of new strings to translate, too. Hope to find some time next week 🤞🏻 Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No probs, thx!
This should make the display more pleasing in the bottom menu bar by shortening the label