Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Posta in arrivo" with "Notifiche" #826

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Replace "Posta in arrivo" with "Notifiche" #826

merged 5 commits into from
Jul 3, 2023

Conversation

andreaippo
Copy link
Contributor

@andreaippo andreaippo commented Jun 22, 2023

This should make the display more pleasing in the bottom menu bar by shortening the label

This avoid issues with the label in the bottom menu bar
@Krusty27
Copy link

I don't think that using an english word makes much sense for an italian translation. Wouldn't "messaggi" or "notifiche" be better?

@NicKoehler
Copy link

NicKoehler commented Jun 22, 2023

"Posta" would be good enough

@andreaippo
Copy link
Contributor Author

TBH I'm not proud of this change. It feels like a workaround to solve a problem that should be fixed differently (via proper hyphenation, for example).

So do with this what you will. I'm not a fan of Posta or Messaggi since one is a bit vague and the other a bit misleading. But I understand the criticism towards an English term, and in that case maybe the best option is wrapping words properly in the UI (if feasible, I'm not an Android dev).

@MV-GH
Copy link
Collaborator

MV-GH commented Jun 22, 2023

What you mean wrapping the words? Isn't doing that already, if its too long it should put the text below it see #818

@andscape-dev
Copy link
Contributor

If it's necessary to have a single-word replacement I think "notifiche" is the most appropriate solution

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notifiche seems like a better fit then

@andreaippo andreaippo changed the title Replace "Posta in arrivo" with "Inbox" Replace "Posta in arrivo" with "Notifiche" Jun 29, 2023
@andreaippo
Copy link
Contributor Author

andreaippo commented Jun 29, 2023

Really sorry everyone, I just found a few minutes now to update the PR and I'm on GitHub for Android on top of that.

I hope the diff looks good now. @dessalines

I've rebased my branch and at the pace development is happening there's probably a bunch of new strings to translate, too.

Hope to find some time next week 🤞🏻

Thanks

@MV-GH MV-GH enabled auto-merge (squash) July 1, 2023 14:58
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No probs, thx!

@dessalines dessalines disabled auto-merge July 3, 2023 13:54
@dessalines dessalines merged commit 7f470a1 into LemmyNet:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants