-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(German Translation) Ugly line break in bottom Navbar #818
Comments
A similarly ugly screenshot: |
Same issue here. Please use an ellipsis ("Posteing...", "Lesezei...") when the text doesn't fit in one line. |
Truncating and wrapping text in NavigationBars is discouraged by Material.io guidelines: https://m3.material.io/components/navigation-bar/guidelines I'd really like to try how it looks with reduced padding between icons but I feel we have to completely rewrite the component because I've found no way to inject smaller padding with modifiers. And rewriting is far beyond my skill level and available time. Another idea could be to not use labels at as the icons are pretty descriptive in itself. |
so, what's the alternative? I don't see any actionable advice, besides coming up with a shorter label, but that is difficult.
And this solves the problem for German, but not for other languages. |
Also, I noticed that the label font size in Google Drive is smaller than in Google Photos. So even though it's discouraged to make a label smaller to fit the text, it is apparently OK to make all labels smaller by the same amount. |
I'm
I'm no Android dev so I'm not familiar with their design guidelines, but from a user perspective it would seem very off and low quality to have just one label smaller. In which case #826 can be closed. |
I think we're all on the same page regarding resizing only the labels that are too long. That's pretty much off the table. I think making all labels smaller is something that can be tested but I'm wondering whether this is something we can implement per language because I see no reason to make English labels smaller and therefore lessen their readibility because we Germans and Italians have issues with labels that are too long. |
I think the best solution would be a combination:
|
Add the possibility to show icons only and we're done |
Yeah, this is pretty rough. At first, it's probably easiest to just add an option to just show the icons. |
Jerboa Version
main branch
Describe the bug
The words "Posteingang" and "Lesezeichen" have ugly line breaks.
This happens on my OnePlus 5t.
See:
![Screenshot_20230622-175700__01](https://private-user-images.githubusercontent.com/870042/247990356-ae43bdd1-a35c-4bef-a23c-9c137846f873.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTgwNzUsIm5iZiI6MTczOTY1Nzc3NSwicGF0aCI6Ii84NzAwNDIvMjQ3OTkwMzU2LWFlNDNiZGQxLWEzNWMtNGJlZi1hMjNjLTljMTM3ODQ2Zjg3My5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQyMjE2MTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yODM5ZTJiNjljYTViNGNlNTFjYjM2M2EwYzMxNWEzZTNlMTc4MGEyZjJhYWZlZmZiMjYxMWU5ZWM5ZjNhZGYyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.0WPicz-vUnSfaXPB7BhAOYteh5VBiNKPRmbSQZQSR3o)
I'll try to look into this later this evening. Maybe it's enough to adjust the padding of those buttons.
Is there any lower resolution limit Jerboas GUI has to work flawlessly?
The text was updated successfully, but these errors were encountered: