Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(German Translation) Ugly line break in bottom Navbar #818

Closed
sockenklaus opened this issue Jun 22, 2023 · 10 comments
Closed

(German Translation) Ugly line break in bottom Navbar #818

sockenklaus opened this issue Jun 22, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@sockenklaus
Copy link
Contributor

Jerboa Version
main branch

Describe the bug
The words "Posteingang" and "Lesezeichen" have ugly line breaks.

This happens on my OnePlus 5t.

  • Size: 6.01 inch
  • Resolution: 2160 X 1080.

See:
Screenshot_20230622-175700__01

I'll try to look into this later this evening. Maybe it's enough to adjust the padding of those buttons.

Is there any lower resolution limit Jerboas GUI has to work flawlessly?

@sockenklaus sockenklaus added the bug Something isn't working label Jun 22, 2023
@sockenklaus sockenklaus changed the title (German Translation) Ugly line break I'm bottom Navbar (German Translation) Ugly line break in bottom Navbar Jun 22, 2023
@andreaippo
Copy link
Contributor

A similarly ugly screenshot:

https://lemm.ee/post/238562

@Aloso
Copy link

Aloso commented Jun 25, 2023

Same issue here. Please use an ellipsis ("Posteing...", "Lesezei...") when the text doesn't fit in one line.

@sockenklaus
Copy link
Contributor Author

sockenklaus commented Jun 25, 2023

Truncating and wrapping text in NavigationBars is discouraged by Material.io guidelines:

https://m3.material.io/components/navigation-bar/guidelines

I'd really like to try how it looks with reduced padding between icons but I feel we have to completely rewrite the component because I've found no way to inject smaller padding with modifiers. And rewriting is far beyond my skill level and available time.

Another idea could be to not use labels at as the icons are pretty descriptive in itself.

@Aloso
Copy link

Aloso commented Jun 25, 2023

Truncating and wrapping text in NavigationBars is discouraged by Material.io guidelines

so, what's the alternative? I don't see any actionable advice, besides coming up with a shorter label, but that is difficult.

  • Instead of Posteingang (inbox), we could use Postfach (mailbox / post office box), which is shorter but less descriptive.

  • Instead of Lesezeichen (bookmarks), we could use Gemerkt (remembered / bookmarked), or Favoriten (favourites), but then the Android app uses different terminology than the web app, which might confuse people.

And this solves the problem for German, but not for other languages.

@Aloso
Copy link

Aloso commented Jun 25, 2023

Also, I noticed that the label font size in Google Drive is smaller than in Google Photos. So even though it's discouraged to make a label smaller to fit the text, it is apparently OK to make all labels smaller by the same amount.

@andreaippo
Copy link
Contributor

andreaippo commented Jun 26, 2023

I'm

Also, I noticed that the label font size in Google Drive is smaller than in Google Photos. So even though it's discouraged to make a label smaller to fit the text, it is apparently OK to make all labels smaller by the same amount.

I'm no Android dev so I'm not familiar with their design guidelines, but from a user perspective it would seem very off and low quality to have just one label smaller.
Rephrasing things (sometimes losing part of their meaning) just to make them fit also seems a subpar solution to the problem to me. I'd definitely regard the smaller labels for all solution as the more elegant and consistent one here.

In which case #826 can be closed.

@sockenklaus
Copy link
Contributor Author

I'm no Android dev so I'm not familiar with their design guidelines, but from a user perspective it would seem very off and low quality to have just one label smaller. Rephrasing things (sometimes losing part of their meaning) just to make them fit also seems a subpar solution to the problem to me. I'd definitely regard the smaller labels for all solution as the more elegant and consistent one here.

I think we're all on the same page regarding resizing only the labels that are too long. That's pretty much off the table.

I think making all labels smaller is something that can be tested but I'm wondering whether this is something we can implement per language because I see no reason to make English labels smaller and therefore lessen their readibility because we Germans and Italians have issues with labels that are too long.

@Aloso
Copy link

Aloso commented Jun 26, 2023

I think the best solution would be a combination:

  • Try to use shorter words as labels where it makes sense
  • Decrease the font size slightly, so it's still easily readable
  • When the text overflows, use an ellipsis as a last resort

@suoko
Copy link

suoko commented Jun 28, 2023

Add the possibility to show icons only and we're done

@shtrophic
Copy link
Contributor

Yeah, this is pretty rough. At first, it's probably easiest to just add an option to just show the icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants