Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Accesibility Tweaks #674

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Small Accesibility Tweaks #674

merged 3 commits into from
Jun 16, 2023

Conversation

scottmmjackson
Copy link
Contributor

  • Dropped "todo" from the community icon description
  • Changed "Select listing filter" to "select feed"
  • Changed "Select sort option" to "sort by"- this affects multiple components
  • Changed "Show more options" to "more options"
  • Changed the way vote component descriptions are written. The type and vote are used to select among "upvote", "upvoted", "downvote", and "downvoted"
  • Changed "Select inbox filter" to "filter"

Fixes #616

scottmmjackson
scottmmjackson commented Jun 15, 2023
View reviewed changes
app/src/main/res/values/strings.xml
@@ -289,4 +289,8 @@
<string name="topAppBar_back">Back</string>
<string name="utils_login_first">Login first</string>
<string name="voteToggle">Toggle vote</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't drop this because I'm not sure of the implications since it's been translated a bunch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they aren't used, they should be deleted including the translations imo. Would need a code owner to make the final verdict.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its unused and not expected to be used again we should remove it, but it doesn't have to be in this PR necessarily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Drop voteToggle unused string resource

@twizmwazin twizmwazin enabled auto-merge (squash) June 15, 2023 18:05
@twizmwazin twizmwazin merged commit 2c35ab1 into LemmyNet:main Jun 16, 2023
@scottmmjackson scottmmjackson mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV-GH MV-GH MV-GH left review comments

@twizmwazin twizmwazin twizmwazin approved these changes

@dessalines dessalines Awaiting requested review from dessalines dessalines is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small Accessibility Tweaks
3 participants
@scottmmjackson @twizmwazin @MV-GH