Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp fix for crash sometimes on read more replies to bug introduced in lemmy 18.3 #1113

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Temp fix for crash sometimes on read more replies to bug introduced in lemmy 18.3 #1113

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a84eb57
Don't use commentId as key
MV-GH Jul 30, 2023
52e599b
Fix formatting
MV-GH Jul 30, 2023
dc0aa18
Fix formatting
MV-GH Jul 30, 2023
bc4f124
Trigger woodpecker
MV-GH Jul 30, 2023
2d48e9c
Merge branch 'main' into fix/1109
MV-GH Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@ fun LazyListScope.commentNodeItem(
increaseLazyListIndexTracker()
// TODO Needs a contentType
// possibly "contentNodeItemL${node.depth}"
item(key = commentId) {
item(key = null) {
// TODO was commentId but see #1109, changeback once bug has been fixed
var viewSource by remember { mutableStateOf(false) }

val backgroundColor = MaterialTheme.colorScheme.background
Expand Down