Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp fix for crash sometimes on read more replies to bug introduced in lemmy 18.3 #1113

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jul 30, 2023

This change does not change any functionality.

If null is passed the position in the list will represent the key.

But instead of crashing now when it returns a duplicate comment it will insert a duplicate comment

Fix for #1109

I have encountered this crash several times already since 18.3 deployed.

This apk has the fix
app-release.zip

@MV-GH MV-GH changed the title Fix temp crash sometimes on read more replies on 18.3 due to bug introduced in lemmy Temp fix for crash sometimes on read more replies on 18.3 due to bug introduced in lemmy Jul 30, 2023
@MV-GH MV-GH changed the title Temp fix for crash sometimes on read more replies on 18.3 due to bug introduced in lemmy Temp fix for crash sometimes on read more replies to bug introduced in lemmy 18.3 Jul 30, 2023
@twizmwazin twizmwazin merged commit 2e693a7 into LemmyNet:main Aug 1, 2023
@MV-GH MV-GH deleted the fix/1109 branch August 1, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants