Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert a few Int-based settings params into enums #1352

Closed
3 tasks done
dessalines opened this issue Feb 6, 2024 · 0 comments · Fixed by #1369
Closed
3 tasks done

Convert a few Int-based settings params into enums #1352

dessalines opened this issue Feb 6, 2024 · 0 comments · Fixed by #1369
Labels
1 - low priority This issue is nice to have but not imminently planned. If you need it soon, consider making a PR enhancement New feature or request

Comments

@dessalines
Copy link
Member

Pre-Flight checklist

  • Did you check to see if this issue already exists?
  • This is a single feature request. (Do not put multiple feature requests in one issue)
  • This is not a question or discussion. (Use https://lemmy.ml/c/jerboa for that)

Describe The Feature Request Below

In the code there are a few settings passed as params, such as blurNSFW, postActionBarMode (and possibly others), that should be using their Enums rather than Ints. Otherwise its not clear what blurNSFW: 2 means.
@dessalines dessalines added enhancement New feature or request 1 - low priority This issue is nice to have but not imminently planned. If you need it soon, consider making a PR labels Feb 6, 2024
dessalines added a commit that referenced this issue Feb 10, 2024
@dessalines
Switch blurNSFW and postActionBarMode to use enums.
73487ad 
- Fixed some naming.
- Also cleaned up imports.
- Fixes #1352
@dessalines dessalines mentioned this issue Feb 10, 2024
Merged
dessalines added a commit that referenced this issue Feb 10, 2024
@dessalines
Switch blurNSFW and postActionBarMode to use enums. (#1369)
933e003 
- Fixed some naming.
- Also cleaned up imports.
- Fixes #1352
dessalines added a commit that referenced this issue Feb 11, 2024
@dessalines
Switch blurNSFW and postActionBarMode to use enums. (#1369)
998e30f 
- Fixed some naming.
- Also cleaned up imports.
- Fixes #1352
dessalines added a commit that referenced this issue Feb 12, 2024
@dessalines
Using muted federated names. (#1368)
8c9c615 
* Using muted federated names.

- Also replaces overflowing text with simple marquees.
- Fixes #1364

* A few simplifications.

* A few updates.

* Remove material1 LocalContentColor. (#1366)

* Fixing comment bottom margin. Fixes #1365 (#1367)

* Switch blurNSFW and postActionBarMode to use enums. (#1369)

- Fixed some naming.
- Also cleaned up imports.
- Fixes #1352

* Dont show comment content when its deleted or removed. (#1371)

- Fixes #1335

* Use medium padding.

* A few more fixes.

* A few more fixes.

* Addressing comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - low priority This issue is nice to have but not imminently planned. If you need it soon, consider making a PR enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch blurNSFW and postActionBarMode to use enums. LemmyNet/jerboa
1 participant
@dessalines