Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When replying to a deleted comment, you can then easily see the text. #1335

Closed
dessalines opened this issue Jan 26, 2024 · 0 comments · Fixed by #1371
Closed

When replying to a deleted comment, you can then easily see the text. #1335

dessalines opened this issue Jan 26, 2024 · 0 comments · Fixed by #1371
Labels
bug Something isn't working

Comments

@dessalines
Copy link
Member

Jerboa Version

main

Android Version + Phone

NA

Describe The Bug

When replying to a deleted comment, you can then easily see the text, which should not be visible.

Two solutions are possible:

  • Don't show the reply button for deleted / removed comments.
  • Make sure the reply activity properly handles the deleted field.

To Reproduce

  1. Check a deleted comment. It properly shows deleted
  2. Click reply, you can now see the comment

In the case of a crash or when relevant include the logs

No response
@dessalines dessalines added the bug Something isn't working label Jan 26, 2024
dessalines added a commit that referenced this issue Feb 11, 2024
@dessalines
Dont show comment content when its deleted or removed.
0241795 
- Fixes #1335
@dessalines dessalines mentioned this issue Feb 11, 2024
Merged
dessalines added a commit that referenced this issue Feb 11, 2024
@dessalines
Dont show comment content when its deleted or removed. (#1371)
c435926 
- Fixes #1335
dessalines added a commit that referenced this issue Feb 11, 2024
@dessalines
Dont show comment content when its deleted or removed. (#1371)
92791be 
- Fixes #1335
dessalines added a commit that referenced this issue Feb 12, 2024
@dessalines
Using muted federated names. (#1368)
8c9c615 
* Using muted federated names.

- Also replaces overflowing text with simple marquees.
- Fixes #1364

* A few simplifications.

* A few updates.

* Remove material1 LocalContentColor. (#1366)

* Fixing comment bottom margin. Fixes #1365 (#1367)

* Switch blurNSFW and postActionBarMode to use enums. (#1369)

- Fixed some naming.
- Also cleaned up imports.
- Fixes #1352

* Dont show comment content when its deleted or removed. (#1371)

- Fixes #1335

* Use medium padding.

* A few more fixes.

* A few more fixes.

* Addressing comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dont show comment content when its deleted or removed. LemmyNet/jerboa
1 participant
@dessalines