Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm): ⚡️ fix braze related performance issues #8872

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Jan 10, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Fix the braze related performance issue introduced by #8576.
This fix was already merged into the release branch by #8870.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner January 10, 2025 15:21
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jan 10, 2025 3:21pm
native-ui-storybook ⬜️ Ignored (Inspect) Jan 10, 2025 3:21pm
react-ui-storybook ⬜️ Ignored (Inspect) Jan 10, 2025 3:21pm
web-tools ⬜️ Ignored (Inspect) Jan 10, 2025 3:21pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jan 10, 2025
@thesan thesan merged commit 203e7ef into develop Jan 10, 2025
42 of 44 checks passed
@thesan thesan deleted the fix/llm-braze-perfs branch January 10, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant