Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llm): ✨ log content card impression when 50% of the card is shown #8576

Merged

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Dec 3, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

This is the squashed commit from #8526

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

…wn (#8526)

* feat(llm): log category cards impression when 50% of the card is visible

* feat(llm): do not run in view checks when no items is being watched

* feat(llm): log portfolio content cards impression on 50% visibility

* chore: update change log

* feat(llm): log dynamic content card impression when 50% is shown

* feat(llm): log notification impression when 50% is shown

* chore(llm): rename IsInViewContext to InViewContext

* chore(llm): add InViewContextProvider to the AppProviders

* fix(llm): undefined order in null

* feat(lld): log category impression when 50% is shown

* chore(llm): use LLM alias in imports

* feat(llm): trigger segment event on card impression

* fix(llm): rewatch card when `LogContentCardWrapper.id` change

* fix(llm): use mobileCardsSelector to find the card to log the impression

* fix(llm): race condition between interval and inViewStatus

* chore(llm): check "exhaustive-deps" on `useInViewContext`

* chore(llm): remove unnecessary key
@thesan thesan requested a review from a team as a code owner December 3, 2024 11:08
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 11:16am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 11:16am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 11:16am
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 11:16am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 3, 2024
@thesan thesan merged commit 64ed0a4 into release Dec 3, 2024
48 of 52 checks passed
@thesan thesan deleted the feat/llm-enhanced-ccard-impression-tracking-release branch December 3, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants