Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change label to yield for uk, earn for the rest for bottom navigator llm #8460

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Change label to yield for uk, earn for the rest for bottom navigator llm #8460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38aa5b2
change label to yield for uk, earn for the rest for bottom navigator …
adammino-ledger Nov 25, 2024
5a38a12
added changeset
adammino-ledger Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ten-birds-admire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"live-mobile": minor
---

change bottom nav label for Earn to Yield just for UK locale
5 changes: 3 additions & 2 deletions apps/ledger-live-mobile/src/components/RootNavigator/MainNavigator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import customTabBar from "../TabBar/CustomTabBar";
import { MainNavigatorParamList } from "./types/MainNavigator";
import { isMainNavigatorVisibleSelector } from "~/reducers/appstate";
import EarnLiveAppNavigator from "./EarnLiveAppNavigator";
import { getStakeLabelLocaleBased } from "~/helpers/getStakeLabelLocaleBased";

const Tab = createBottomTabNavigator<MainNavigatorParamList>();

Expand All @@ -35,7 +36,7 @@ export default function MainNavigator() {
const isMainNavigatorVisible = useSelector(isMainNavigatorVisibleSelector);
const managerNavLockCallback = useManagerNavLockCallback();
const web3hub = useFeature("web3hub");

const earnYiedlLabel = getStakeLabelLocaleBased();
const insets = useSafeAreaInsets();
const tabBar = useMemo(
() =>
Expand Down Expand Up @@ -108,7 +109,7 @@ export default function MainNavigator() {
tabBarIcon: props => (
<TabIcon
Icon={IconsLegacy.LendMedium}
i18nKey="tabs.earn"
i18nKey={earnYiedlLabel}
testID="tab-bar-earn"
{...props}
/>
Expand Down
Loading