Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change label to yield for uk, earn for the rest for bottom navigator llm #8460

Merged

Conversation

adammino-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Label of bottom navigator for Earn changed to Yield just when in UK locale

πŸ“ Description

Change label to yield for uk, earn for the rest for bottom navigator in llm.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 25, 2024 0:39am
native-ui-storybook ⬜️ Ignored (Inspect) Nov 25, 2024 0:39am
react-ui-storybook ⬜️ Ignored (Inspect) Nov 25, 2024 0:39am
web-tools ⬜️ Ignored (Inspect) Nov 25, 2024 0:39am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Nov 25, 2024
@adammino-ledger adammino-ledger merged commit b679734 into develop Nov 25, 2024
41 of 42 checks passed
@adammino-ledger adammino-ledger deleted the feat/change-label-to-yield-for-uk-bottom-nav-llm branch November 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants