Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/cache swap providers #6979

Merged
merged 2 commits into from
May 30, 2024
Merged

Bugfix/cache swap providers #6979

merged 2 commits into from
May 30, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented May 30, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

small cache to prevent be call spam from swap providers data

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner May 30, 2024 13:59
@vercel Vercel
Copy link

vercel bot commented May 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 2:03pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 2:03pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 2:03pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 2:03pm
web-tools ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 2:03pm

@live-github-bot live-github-bot bot added the common Has changes in live-common label May 30, 2024
@CremaFR CremaFR mentioned this pull request May 30, 2024
Merged
3 tasks
@CremaFR CremaFR closed this May 30, 2024
@CremaFR CremaFR reopened this May 30, 2024
@CremaFR CremaFR merged commit 55fdf88 into develop May 30, 2024
99 checks passed
@CremaFR CremaFR deleted the bugfix/cache-swap-providers branch May 30, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpellizzari-ledger cpellizzari-ledger cpellizzari-ledger approved these changes

Assignees

@CremaFR CremaFR

Labels
common Has changes in live-common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CremaFR @cpellizzari-ledger