-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(live-common/exchange): fix CAL service integration #6968
fix(live-common/exchange): fix CAL service integration #6968
Conversation
- fix internal URL used, bypassing Cloudflare cache - fix unused field requested - limit request to swap partners - add X-Ledger-Client-Version header for monitoring
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minimal change suggested: just replace the header by
"X-Ledger-Client-Version": getEnv("LEDGER_CLIENT_VERSION")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I wasn't aware of this too
closing #6979
@CremaFR @lpaquet-ledger (I don't have merge rights) |
* fix(live-common/exchange): fix CAL service integration - fix internal URL used, bypassing Cloudflare cache - fix unused field requested - limit request to swap partners - add X-Ledger-Client-Version header for monitoring * fix(live-common/exchange): replace fetch() with @ledgerhq/live-network
β Checklist
npx changeset
was attached.π Description
Followup of #6853:
X-Ledger-Client-Version
header for monitoringI did not fix in this PR:
fetch()
is the preferred way in Ledger Live. Other parts of Ledger Live usenetwork
shared lib that sets theX-Ledger-Client-Version
header we need for monitoring: https://github.com/LedgerHQ/ledger-live/blob/develop/libs/live-network/src/network.ts#L251β Context
π§ Checklist for the PR Reviewers