Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log message improvements #70

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Log message improvements #70

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c38b98
Log message improvements
jianoaix Nov 21, 2023
0f0a5bd
Feedback
jianoaix Nov 22, 2023
bd68fe9
fix
jianoaix Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion node/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func (n *Node) Start(ctx context.Context) error {
// Build the socket based on the hostname/IP provided in the CLI
socket := string(core.MakeOperatorSocket(n.Config.Hostname, n.Config.DispersalPort, n.Config.RetrievalPort))
if n.Config.RegisterNodeAtStart {
n.Logger.Debug("Registering node on chain with the following parameters:", "operatorId",
n.Logger.Info("Registering node on chain with the following parameters:", "operatorId",
n.Config.ID, "hostname", n.Config.Hostname, "dispersalPort", n.Config.DispersalPort,
"retrievalPort", n.Config.RetrievalPort, "churnerUrl", n.Config.ChurnerUrl, "quorumIds", n.Config.QuorumIDList)
socket := string(core.MakeOperatorSocket(n.Config.Hostname, n.Config.DispersalPort, n.Config.RetrievalPort))
Expand All @@ -179,6 +179,8 @@ func (n *Node) Start(ctx context.Context) error {
if err != nil {
return fmt.Errorf("failed to register the operator: %w", err)
}
} else {
n.Logger.Info("The node is started, but it's not opt-in in EigenDA yet (it's not receiving and validating data in EigenDA). To register, please follow the guide in https://docs.eigenlayer.xyz/operator-guides/avs-installation-and-registration/eigenda-operator-guide/eigenda-avs-installation-and-registration")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super helpful!

There might be a typo at the "opt-in in" vs "opt-in to"?

If we can avoid direct links to the docs URL that would be safest. Those URLs are unfortunately, subject to change in the near-mid term.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced it with the github repo which should be stable.

}

n.CurrentSocket = socket
Expand Down
Loading