Log message improvements #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesfloyd
reviewed
Nov 22, 2023
node/node.go
Outdated
| @@ -179,6 +179,8 @@ func (n *Node) Start(ctx context.Context) error { | |||
| if err != nil { | |||
| return fmt.Errorf("failed to register the operator: %w", err) | |||
| } | |||
| } else { | |||
| n.Logger.Info("The node is started, but it's not opt-in in EigenDA yet (it's not receiving and validating data in EigenDA). To register, please follow the guide in https://docs.eigenlayer.xyz/operator-guides/avs-installation-and-registration/eigenda-operator-guide/eigenda-avs-installation-and-registration") | |||
There was a problem hiding this comment.
Super helpful!
There might be a typo at the "opt-in in" vs "opt-in to"?
If we can avoid direct links to the docs URL that would be safest. Those URLs are unfortunately, subject to change in the near-mid term.
There was a problem hiding this comment.
Replaced it with the github repo which should be stable.
wesfloyd
approved these changes
Nov 22, 2023
ian-shim
approved these changes
Nov 22, 2023
teddyknox
pushed a commit
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Log message improvement based on feedback
Checks