Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API cleanup #243

Merged
merged 4 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 35 additions & 35 deletions api/grpc/churner/churner.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/grpc/disperser/disperser.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions api/proto/churner/churner.proto
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,23 @@ service Churner {
}

message ChurnRequest {
// The Ethereum address (in hex like "0x123abcdef...") of the operator.
string operator_address = 1;
Comment on lines +21 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this need to be moved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator address is a primary element

// The operator making the churn request.
bytes operator_to_register_pubkey_g1 = 1;
bytes operator_to_register_pubkey_g2 = 2;
bytes operator_to_register_pubkey_g1 = 2;
bytes operator_to_register_pubkey_g2 = 3;
// The operator's BLS signature signed on the keccak256 hash of
// concat("ChurnRequest", g1, g2, salt).
bytes operator_request_signature = 3;
// concat("ChurnRequest", operator address, g1, g2, salt).
bytes operator_request_signature = 4;
// The salt used as part of the message to sign on for operator_request_signature.
bytes salt = 4;
bytes salt = 5;
// The quorums to register for.
// Note:
// - If any of the quorum here has already been registered, this entire request
// will fail to proceed.
// - If any of the quorum fails to register, this entire request will fail.
// The IDs must be in range [0, 254].
repeated uint32 quorum_ids = 5;
// The Ethereum address (in hex like "0x123abcdef...") of the operator.
string operator_address = 6;
// The IDs must be in range [0, 255].
repeated uint32 quorum_ids = 6;
}

message ChurnReply {
Expand Down
2 changes: 1 addition & 1 deletion api/proto/disperser/disperser.proto
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ message AuthenticationData {

message DisperseBlobRequest {
// The data to be dispersed.
// The size of data must be <= 512KiB.
// The size of data must be <= 2MiB.
bytes data = 1;
// Security parameters allowing clients to customize the safety (via adversary threshold)
// and liveness (via quorum threshold).
Expand Down
Loading