Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API cleanup #243

Merged
merged 4 commits into from
Feb 6, 2024
Merged

API cleanup #243

merged 4 commits into from
Feb 6, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Feb 6, 2024

Why are these changes needed?

API review, cleanup, and make incompatible adjustments to ride the v0.3.0 release.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lets check in the generated files as well

Comment on lines +21 to +22
// The Ethereum address (in hex like "0x123abcdef...") of the operator.
string operator_address = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this need to be moved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator address is a primary element

@jianoaix jianoaix merged commit ff3a002 into Layr-Labs:master Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants